[tkinter] Allow any return value for invalidcommand - #16252
Open
ekanshul wants to merge 1 commit into
Open
Conversation
Tk only evaluates the invalidcommand (invcmd) script when validatecommand returns false and ignores whatever it returns, so Callable[[], bool] was too strict and rejected ordinary callbacks that return None. Widen it to Callable[[], object] on all Entry, Spinbox, ttk.Entry, ttk.Combobox and ttk.Spinbox sites. validatecommand keeps Callable[[], bool] because Tk does use its result. Closes python#10578 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10578
Widen
invalidcommand/invcmdfromCallable[[], bool]toCallable[[], object]on allEntry,Spinbox,ttk.Entry,ttk.Comboboxandttk.Spinboxsites, as suggested in the issue;validatecommandis unchanged.Agent used: Claude Code