[protobuf] Fix internal decoder factory signatures - #16250
Open
ekanshul wants to merge 1 commit into
Open
Conversation
At runtime Int32Decoder through BoolDecoder are factories with the same signature as EnumDecoder (field_number, is_repeated, is_packed, key, new_default, clear_if_default=False), not decoders. The returned decoders and ReadTag receive a memoryview (ReadTag calls .tobytes()), and new_default callables return scalars or containers, not Message. Mirrors the encoder.pyi fix in python#16163. Closes python#10697 Closes python#10698 Closes python#10712 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10697
Closes #10698
Closes #10712
Type the numeric
XxxDecodernames as factories with the same signature asEnumDecoder(mirroring the encoder fix in #16163), make_DecoderandReadTagtake amemoryview, and let_NewDefaultreturnAny, matching the runtime.Agent used: Claude Code