Add cleanup_socket param to asyncio AbstractEventLoop.create_unix_server (3.13+)#15792
Open
b9nn wants to merge 2 commits into
Open
Add cleanup_socket param to asyncio AbstractEventLoop.create_unix_server (3.13+)#15792b9nn wants to merge 2 commits into
b9nn wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
…p_socket mismatch
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15742.
Python 3.13 added a
cleanup_socket: bool = Truekeyword-only parameter toasyncio.loop.create_unix_server(CPython docs: "Changed in version 3.13: Added the cleanup_socket parameter."). The subclass_UnixSelectorEventLoop.create_unix_serverinstdlib/asyncio/unix_events.pyialready declares this parameter for 3.13+, butAbstractEventLoop.create_unix_serverinstdlib/asyncio/events.pyidoes not — so callers typed against the abstract base class get a type error.This PR splits
AbstractEventLoop.create_unix_serverout of the existingstart_tlsif sys.version_info >= (3, 11) / elseblock and gives it its own three-way version conditional:>= (3, 13)— addscleanup_socket: bool = True>= (3, 11)— unchanged from previous 3.11+ signatureelse— unchanged pre-3.11 signaturestart_tlskeeps its existing two-way split. No behavior change for pre-3.13 versions.I used AI assistance to identify the missing parameter location and draft the change. I have reviewed all changes myself and believe they are correct.