Skip to content

Fix Final literal values in various third-party stubs #15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Mar 16, 2026
+13 −13
Merged

Fix Final literal values in various third-party stubs #15521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stubs/docutils/docutils/statemachine.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ _TransitionResult: TypeAlias = tuple[_Context, str | None, list[str]]
_TransitionMethod: TypeAlias = Callable[[Match[str], _Context, str], _TransitionResult[_Context]]
_Observer: TypeAlias = Callable[[StateMachine[_Context]], None]

__docformat__: Final = "reStructuredText"
__docformat__: Final = "restructuredtext"
Copy link
Collaborator Author

@brianschubert brianschubert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/docutils/docutils/blob/e0bed47917df14f8fb93c6e48da3cce7a8f5cac0/docutils/docutils/statemachine.py#L110


class StateMachine(Generic[_Context]):
input_lines: StringList | None
Expand Down
2 changes: 1 addition & 1 deletion stubs/openpyxl/openpyxl/styles/colors.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ _S = TypeVar("_S", bound=Serialisable)
COLOR_INDEX: Final[tuple[str, ...]]
BLACK: Final = "00000000"
WHITE: Final = "00FFFFFF"
BLUE: Final = "00FFFFFF"
BLUE: Final = "000000FF"
Copy link
Collaborator Author

@brianschubert brianschubert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/soxhub/openpyxl/blob/ec884e35f980b6158ae68f5099506a85f12c063d/openpyxl/styles/colors.py#L38

aRGB_REGEX: Final[Pattern[str]]

class RGB(Typed[str, _N]):
Expand Down
10 changes: 5 additions & 5 deletions stubs/pycurl/pycurl.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ CAINFO: Final = 10065
CAINFO_BLOB: Final = 40309
CAPATH: Final = 10097
CLOSESOCKETFUNCTION: Final = 20208
COMPILE_LIBCURL_VERSION_NUM: Final = 525824
COMPILE_PY_VERSION_HEX: Final = 50925040
COMPILE_SSL_LIB: Final = "schannel"
COMPILE_LIBCURL_VERSION_NUM: Final[int]
COMPILE_PY_VERSION_HEX: Final[int]
COMPILE_SSL_LIB: Final[str]
Comment on lines +88 to +90
Copy link
Collaborator Author

@brianschubert brianschubert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstable, depend on the versions the module was compiled with

CONDITION_UNMET: Final = 2097187
CONNECTTIMEOUT: Final = 78
CONNECTTIMEOUT_MS: Final = 156
Expand Down Expand Up @@ -333,7 +333,7 @@ HTTPAUTH_NEGOTIATE: Final = 4
HTTPAUTH_NONE: Final = 0
HTTPAUTH_NTLM: Final = 8
HTTPAUTH_NTLM_WB: Final = 32
HTTPAUTH_ONLY: Final = -2147483648
HTTPAUTH_ONLY: Final[int]
Copy link
Collaborator Author

@brianschubert brianschubert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value differs between platforms: -2147483648 on the Windows runners, +2147483648 on the MacOS and Linux runners

HTTPGET: Final = 80
HTTPHEADER: Final = 10023
HTTPPOST: Final = 10024
Expand Down Expand Up @@ -646,7 +646,7 @@ SSLVERSION_MAX_TLSv1_2: Final = 393216
SSLVERSION_MAX_TLSv1_3: Final = 458752
SSLVERSION_SSLv2: Final = 2
SSLVERSION_SSLv3: Final = 3
SSLVERSION_TLSv1: Final = 0
SSLVERSION_TLSv1: Final = 1
SSLVERSION_TLSv1_0: Final = 4
SSLVERSION_TLSv1_1: Final = 5
SSLVERSION_TLSv1_2: Final = 6
Expand Down
12 changes: 6 additions & 6 deletions stubs/waitress/waitress/rfc7230.pyi
View file
Open in desktop
Copy link
Collaborator Author

@brianschubert brianschubert Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime values have an actual embedded tab character, not \ t
https://github.com/Pylons/waitress/blob/main/src/waitress/rfc7230.py

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from re import Pattern
from typing import Final

BWS: Final = r"[ \t]{0,}?"
BWS: Final = "[ \t]{0,}?"
CHUNK_EXT: Final[str]
CHUNK_EXT_NAME: Final = r"[!#$%&'*+\-.^_`|~0-9A-Za-z]{1,}"
CHUNK_EXT_RE: Final[Pattern[str]]
Expand All @@ -15,14 +15,14 @@ HEXDIG: Final = r"[0-9a-fA-F]"
OBS_TEXT: Final = r"\x80-\xff"
ONLY_DIGIT_RE: Final[Pattern[str]]
ONLY_HEXDIG_RE: Final[Pattern[str]]
OWS: Final = r"[ \t]{0,}?"
QDTEXT: Final = r"[\t !#-[\]-~\x80-\xff]"
QUOTED_PAIR: Final = r"\\([\t \x21-\x7e\x80-\xff])"
OWS: Final = "[ \t]{0,}?"
QDTEXT: Final = "[\t !#-[\\]-~\\x80-\\xff]"
QUOTED_PAIR: Final = "\\\\([\t \\x21-\\x7e\\x80-\\xff])"
QUOTED_PAIR_RE: Final[Pattern[str]]
QUOTED_STRING: Final[str]
QUOTED_STRING_RE: Final[Pattern[str]]
RWS: Final = r"[ \t]{1,}?"
RWS: Final = "[ \t]{1,}?"
TCHAR: Final = r"[!#$%&'*+\-.^_`|~0-9A-Za-z]"
TOKEN: Final = r"[!#$%&'*+\-.^_`|~0-9A-Za-z]{1,}"
VCHAR: Final = r"\x21-\x7e"
WS: Final = r"[ \t]"
WS: Final = "[ \t]"
Loading