Skip to content

Remove "64-bit universal2" from the macOS installer description #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
Merged

Remove "64-bit universal2" from the macOS installer description #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8460ae1
Remove 'universal2' from the macOS installer description
hugovk Nov 27, 2025
4e69938
Remove '64-bit' from the macOS installer description
hugovk Dec 1, 2025
a935848
fixup! Remove '64-bit' from the macOS installer description
hugovk Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def run_cmd(
}


def macos_universal2_description(version: tuple[int, int, int]) -> str:
def macos_description(version: tuple[int, int, int]) -> str:
if version >= (3, 14):
return "for macOS 10.15 and later"
elif version >= (3, 12, 6):
Expand Down Expand Up @@ -173,10 +173,10 @@ def get_file_descriptions(
(
rx(r"-macos(x)?1[1-9](\.[0-9]*)?\.pkg$"),
(
"macOS 64-bit universal2 installer",
"macOS installer",
"macos",
True,
macos_universal2_description(v),
macos_description(v),
),
),
(
Expand Down
8 changes: 3 additions & 5 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,8 @@ def test_minor_version_tuple(release: str, expected: tuple[int, int]) -> None:
((3, 14, 0), "for macOS 10.15 and later"),
],
)
def test_macos_universal2_description(
release: tuple[int, int, int], expected: str
) -> None:
assert add_to_pydotorg.macos_universal2_description(release) == expected
def test_macos_description(release: tuple[int, int, int], expected: str) -> None:
assert add_to_pydotorg.macos_description(release) == expected


def test_list_files(fs: FakeFilesystem) -> None:
Expand Down Expand Up @@ -214,7 +212,7 @@ def test_list_files(fs: FakeFilesystem) -> None:
),
(
"python-3.14.0b3-macos11.pkg",
"macOS 64-bit universal2 installer",
"macOS installer",
"macos",
True,
"for macOS 10.15 and later",
Expand Down