Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 667: Clarify impact on PyEval_GetLocals #3809

Closed

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jun 2, 2024

See Implementation Notes in the updated PEP for details of the correction/clarification and the rationale for it.

The discrepancy was detected when writing the documentation for python/cpython#74929 and when reviewing python/cpython#118934

  • Change is:
    • To an Accepted or Final PEP, with Steering Council approval
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--3809.org.readthedocs.build/

See Implementation Notes in the updated PEP for details
of the correction/clarification and the rationale for it.

The discrepancy was detected when writing the documentation for
python/cpython#74929 and when reviewing
python/cpython#118934
@ncoghlan ncoghlan marked this pull request as draft June 3, 2024 16:20
@ncoghlan
Copy link
Contributor Author

ncoghlan commented Jun 3, 2024

Converted to draft, as the discussion on python/cpython#119769 makes it clear the end state for the PyEval_GetLocals() semantics isn't actually certain yet.

@ncoghlan
Copy link
Contributor Author

ncoghlan commented Jun 5, 2024

Request to the SC posted to ask for help in choosing the semantics implemented for PyEval_GetLocals in 3.13+: python/steering-council#245 (comment)

@ncoghlan ncoghlan marked this pull request as ready for review June 21, 2024 15:39
@ncoghlan
Copy link
Contributor Author

SC has confirmed that PyEval_GetLocals should retain its 3.12 behaviour: python/steering-council#245 (comment)

peps/pep-0667.rst Outdated Show resolved Hide resolved
Co-authored-by: Jelle Zijlstra <[email protected]>
@ncoghlan
Copy link
Contributor Author

I am combining this PR with the one clarifying the Python API changes in #3845 rather than keeping them separate.

@ncoghlan ncoghlan closed this Jun 25, 2024
@ncoghlan ncoghlan deleted the pep-667-clarify-pyeval_getlocals branch July 4, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants