Infra: Add directives to show warning banner for deprecated PEPs #3682
Conversation
CAM-Gerlach
added
enhancement
infra
There was a problem hiding this comment.
This is a great improvement overall; thanks @hugovk ! I just had a few comments on the implementation and on some of the individual PEP notices. Thanks!
pep_sphinx_extensions/pep_processor/parsing/pep_banner_directive.py
Outdated
Show resolved
Hide resolved
|
Thanks for the review! I'll follow up on the other items tomorrow :) |
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
|
@CAM-Gerlach Review comments addressed, thanks! |
|
If there's no further comments let's merge and work on the remainder in batches. |
hugovk
requested review from
ncoghlan,
dstufft,
malemburg,
Yhg1s,
jeremyhylton,
warsaw,
AA-Turner and
a team
as code owners
|
LGTM, but I would have waited more than just 3 minutes for reviews of all the PEP owners 😄 |
|
Ah sorry, will wait longer for the next batch! And to further teach me a lesson, I've actually noticed a problem, it's only rendering the "Important" header and not the text saying "This PEP has been withdrawn etc".: 
https://peps.python.org/pep-0003/ It should be: 
It was okay originally, and I think I must have checked a cached version after updating the branch from |
|
Please see PR #3756 as a followup. |
For #2719.
(Draft to avoid pinging codeowners.)
Add directives for
abandoned,rejected, superseded or withdrawn PEPs.Apply the directive to the first few as a demo.
📚 Documentation preview 📚: https://pep-previews--3682.org.readthedocs.build/#abandoned-withdrawn-and-rejected-peps