Skip to content

[mypyc]Fix reference leak in mypyc bytes concatenation #21469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinxu2020 wants to merge 4 commits into
base: master
Choose a base branch
from
+28 −1
Open

[mypyc]Fix reference leak in mypyc bytes concatenation #21469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec49242
Remove steal flag from bytes concatenation
colinxu2020 May 12, 2026
9010e28
Add Tests for Bytes Concat
colinxu2020 May 12, 2026
864a11b
fix tests
colinxu2020 May 13, 2026
bcb04d0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mypyc/primitives/bytes_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
return_type=bytes_rprimitive,
c_function_name="CPyBytes_Concat",
error_kind=ERR_MAGIC,
steals=[True, False],
)

# bytes * int
Expand Down
28 changes: 28 additions & 0 deletions mypyc/test-data/refcount.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2125,3 +2125,31 @@ L3:
r8 = box(None, 1)
inc_ref r8
return r8

[case testBytesConcatRefcount]
def f(a: bytes, b: bytes) -> bytes:
return b"1" + a + b
[out]
def f(a, b):
a, b, r0, r1, r2 :: bytes
L0:
r0 = b'1'
r1 = CPyBytes_Concat(r0, a)
r2 = CPyBytes_Concat(r1, b)
dec_ref r1
return r2

[case testChainedBytesConcatRefcount]
def f(a: bytes, b: bytes, c: bytes) -> bytes:
return b"1" + a + b + c
[out]
def f(a, b, c):
a, b, c, r0, r1, r2, r3 :: bytes
L0:
r0 = b'1'
r1 = CPyBytes_Concat(r0, a)
r2 = CPyBytes_Concat(r1, b)
dec_ref r1
r3 = CPyBytes_Concat(r2, c)
dec_ref r2
return r3
Loading