-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Improve match subject inference #19736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cdce8p
wants to merge
1
commit into
python:master
Choose a base branch
from
cdce8p:match-subject-inference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+261
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f62435 to
9cf17b9
Compare
9cf17b9 to
c132ec4
Compare
This comment has been minimized.
This comment has been minimized.
ae3cc0e to
244b1e4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f614291 to
1da718a
Compare
This comment has been minimized.
This comment has been minimized.
1da718a to
9524293
Compare
This comment has been minimized.
This comment has been minimized.
9524293 to
f34840b
Compare
This comment has been minimized.
This comment has been minimized.
f34840b to
df6f5dd
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
9a50d9a to
b77b374
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pytest (https://github.com/pytest-dev/pytest)
+ src/_pytest/assertion/rewrite.py:1023: error: Unused "type: ignore" comment [unused-ignore]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic-match-statement
Python 3.10's match statement
topic-type-narrowing
Conditional type narrowing / binder
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment mypy only infers the type of variables captures inside a match statement. This PR adds additional type information to the match subject itself, similar to
isinstancecalls.Fixes #14911