-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Missing args callable #18990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jdwashin9
wants to merge
34
commits into
python:master
Choose a base branch
from
Jdwashin9:missing-args-callable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Missing args callable #18990
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
7ecb077
types = my_types
b61c9ba
line deleted in suggestions.py
3ff8f89
removing conflict with types.py
6b08c08
changed my_types back to types in suggestions
3930148
build types as standard_types
4b1d260
all python self tests passed 1647
615f869
removing std_types 1802
06f6b73
general code_cleanup 1806
84e9bba
removing unused type: ignores 1812
aad7793
no std types self completely passes
ee5f4b9
fixing build.py 1935
2b38551
adding test case to suggestions.py
e8700fa
fix call expr arg checks and formatting
57d4dd2
edits from diff/prototype included
cc4fcf3
added unpack test cases
lesliehuh e93c401
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 17ebfea
Update checkexpr.py
lesliehuh c4d3d0a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 496db6a
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
lesliehuh e802b54
Revert "Update checkexpr.py"
lesliehuh 1ae0e62
deleted unrelate file changes
lesliehuh 6761e28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f9641dc
deleting erroneous import
lesliehuh 7244902
cleaned code of spacing errors
lesliehuh 97b3730
Delete .github/dependabot.yml
lesliehuh a39cec1
Delete .devcontainer/devcontainer.json
lesliehuh 23a001e
Update stubgen.test
lesliehuh 4badf10
trying to fix internal error from test suite
lesliehuh 96d250c
Merge branch 'python:master' into missing-args-callable
lesliehuh 91703e5
fixing typeshed internal error
lesliehuh b261fae
Merge branch 'master' into missing-args-callable
lesliehuh 0c7b3ab
tweaked tests per recommendation
lesliehuh d9a86c0
Merge branch 'master' into missing-args-callable
lesliehuh a8cb4fc
move typeshed import statement to top
lesliehuh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many questions here... First, why is this code block preceding a docstring?
Second, there's no special-cased "misc" typing construct, this simply shouldn't exist. But fortunately this whole block starting from
is_constructor_call = ...
line is... doing nothing? Is this some kind of merge artifact? I don't see any use of these newly declared variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you requested my review, this comment still applies - I don't see any reason for this whole block of code to exist...