Move inactive experts to emeritus status#1635
Move inactive experts to emeritus status#1635AA-Turner wants to merge 12 commits intopython:mainfrom
Conversation
|
IMO, starting with people who didn't make the GitHub transition would make this much more straightforward. What about adding an “emeriti” table at the end (mapping names to interest areas), to allow restoring the entries quickly -- and determining experts (on things like original design choices) in case the person does add a comment somewhere. |
Agreed. I think this is also needed, since people would otherwise feel kicked out from their expert status (even when they don't contribute to CPython anymore, they are most likely still experts in the resp. fields). It's also a way to thank people who have invested a great amount of time in those areas in the past. |
a4f71fa to
55bd28a
Compare
|
Please excuse the force-push, I've re-ordered the commits to align with @encukou & @malemburg's suggestion of removing pre-GH transition users first, and also adding a new "Experts Emeritus" section. A |
|
It's been nearly two weeks, are there any further comments? |
|
Other than those that were already marked "(inactive)" (and maybe "^"), shall we give the others a courtesy ping to see if they want to stay in the main index? |
|
Hello! Per the above discussion, this PR aims to do some housekeeping on the Experts Index. If you've been pinged here, we are proposing to now list you as an "expert emeritus" for one or more topics. Please let us know if you would like any modifications to the proposed changes in this PR. A cc: @doerwalter @brianquinlan @avassalotti @abalkin @amauryfa @meadori @maxking @eliben @giampaolo @applio @mitsuhiko @freddrake @tarekziade @jackjansen @stevendaprano @gustaebel @rbtcollins @pjenvey @birkenfeld |
|
I would prefer to stay on the active expert list. I don't contribute PRs anymore, but I still watch and review issues around the pickle modules. |
|
LGTM for @brianquinlan |
|
I have recently merged a PR for |
hugovk
left a comment
There was a problem hiding this comment.
Move edelsohn to emeritus for AIX, keep giampaolo for shutil, selectors and ftplib.
| ==================== ============================================= | ||
| Module Maintainers | ||
| ==================== ============================================= | ||
| __future__ |
There was a problem hiding this comment.
I don't see the point of listing modules which have no maintainers. I suggest removing them, but maybe in a separated PR since this PR already changes a lot of things.
|
It seems like the PR has now conflicts. |
|
Seems fine to me. I suggest not calling it 'prune' since you're now keeping us but in a different section. Maybe 'move inactive experts to emeritus status' or something. |
Documentation build overview
Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
|
|
Can you please not remove me (@giampaolo) from ftplib, selectors and subprocess? |
|
Yes, just re-added 👍 |
|
And I'll add back the asterisk. |
hugovk
left a comment
There was a problem hiding this comment.
Will merge this soon if there's no further comments.
Thanks everyone who's been an active expert in the past, we're very grateful for your work! And happy to move you back to the active list in the future, just open a PR, issue or leave a comment here.
We suggest and recommend using the Experts Index for contributors to find a relevant committer/core developer to review a PR or comment on an issue/proposal. Listing names of inactive committers, those who have left the team, or those that never moved from BPO to GitHub can create a frustrating contributor experience.
I've split this change into 5 commits:
left = "..."entry)^entries)We can of course re-add people at any time, this is more of a housekeeping activity than anything else.
A
(I've requested review from the currently listed devguide experts: @merwok @ezio-melotti @willingc @Mariatta @hugovk)
📚 Documentation preview 📚: https://cpython-devguide--1635.org.readthedocs.build/