Skip to content

[3.11] gh-157265: tarfile: Honor None result of filter for link fallbacks (GH-157266) - #157306

Open
miss-islington wants to merge 2 commits into
python:3.11from
miss-islington:backport-fb2f0bb-3.11
Open

miss-islington wants to merge 2 commits into
python:3.11from
miss-islington:backport-fb2f0bb-3.11

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

(cherry picked from commit fb2f0bb)

Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Stan Ulbrych stan@python.org

…cks (pythonGH-157266)

(cherry picked from commit fb2f0bb)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
pythongh-157266: Adjust test for Windows

On Windows (no symlinks, no hardlinks), the behaviour is
the same as without the fix in pythonGH-157266:
- a/t/dummy is extracted
- b/ is extracted
- c/ is *not* created (the target, a/t, is not in the archive)
- c/escape: c/ is created; escape is skipped (target,
   c/../../link_here, is not in archive)
- c is not recreated as a directory
- boom is not created (target is c/escape, which falls back to
  ..\..\link_here, which does not exist in archive)
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 14, 2026
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 47c36b7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157306%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 14, 2026
@encukou
encukou marked this pull request as ready for review September 15, 2026 12:44
@encukou

encukou commented Sep 15, 2026

Copy link
Copy Markdown
Member

None of the buildbots failed on tarfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants