gh-156261: Move converters used in several files to Argument Clinic - #156262
Merged
serhiy-storchaka merged 2 commits intoAug 23, 2026
Conversation
…inic The pid_t, Py_off_t, HANDLE, DWORD and BOOL converters were defined in 9 files. The Py_off_t type and its converter function are now shared too. DWORD in _winapi is used with bitwise=True to keep accepting negative values. The pid_t converter is now used for the pid parameters in the _remote_debugging module, which were declared as int.
serhiy-storchaka
requested review from
a team,
AA-Turner,
erlend-aasland,
gpshead,
pablogsal and
picnixz
as code owners
August 23, 2026 07:58
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pid_t,Py_off_t,HANDLE,DWORDandBOOLconverters were defined in 9 files, not always equivalently. ThePy_off_ttype and its converter function are now shared too.DWORDin_winapiis used withbitwise=True, so that it still accepts negative values, as with the"k"format unit.