gh-156241: Add a no-escape fast path to the _json str escapers - #156242
Open
eendebakpt wants to merge 1 commit into
Open
gh-156241: Add a no-escape fast path to the _json str escapers#156242eendebakpt wants to merge 1 commit into
eendebakpt wants to merge 1 commit into
Conversation
ascii_escape_unicode() and escape_unicode() now return the input bulk-copied with surrounding quotes when nothing needs escaping, via a shared quote_unescaped_unicode() helper, like the writer-based write_escaped_ascii()/write_escaped_unicode() already do in-place. This speeds up json.dumps() of clean strings by 1.2x-2.2x. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ascii_escape_unicode()andescape_unicode()now return the input bulk-copied with surrounding quotes when nothing needs escaping, via a sharedquote_unescaped_unicode()helper, like the writer-basedwrite_escaped_ascii()/write_escaped_unicode()already do.ensure_ascii=FalseBenchmark script
Run with
python bench_escape.py --fast -o out.jsonper build; compare withpyperf compare_to base.json branch.json --table.