gh-150942: Speed up pyexpat attribute parsing - #154860
Open
Punisheroot wants to merge 1 commit into
Open
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
my_StartElementHandler()builds a new dictionary for unordered elementattributes. Use
_PyDict_SetItem_Take2()there so the dictionary insertionconsumes the newly created key and value directly, removing the matching
Py_DECREF()calls on both the success and error paths.This keeps the existing behavior and error handling while doing less reference
count work.
Benchmark
Benchmarks used
pyperf 2.10.0on CPythonmain3.16.0a0 at revision8b048eb35e, built for Windows x64 with the officialPCbuildPGO/PGUpdateconfiguration and link-time code generation. Baseline and patched runs used the
same interpreter and PGO profile; only the
pyexpatextension binary wasswapped. Each worker used CPU 1 affinity and high process priority.
The workloads parse complete XML documents with:
Regular build:
Free-threaded build (
Py_GIL_DISABLED=1,sys._is_gil_enabled() == False):pyperf checkreported both free-threaded result files as stable. The benchmarkis single-threaded, including on the free-threaded interpreter, so it measures
the direct parsing cost rather than concurrent scalability.
Validation
PCbuild\amd64\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped)PCbuild\amd64t\python.exe -m test test_pyexpat: passed (86 tests, 1 skipped)PCbuild\amd64\python_d.exe -m test -R 3:3 test_pyexpat: passedpython.bat -m patchcheck: passedgit diff --check: passed