gh-150587: Harden BINARY_OP_SUBSCR_LIST_INT/STORE_SUBSCR_LIST_INT against non-compact int subscripts#150588
Closed
KRRT7 wants to merge 3 commits into
Closed
gh-150587: Harden BINARY_OP_SUBSCR_LIST_INT/STORE_SUBSCR_LIST_INT against non-compact int subscripts#150588KRRT7 wants to merge 3 commits into
KRRT7 wants to merge 3 commits into
Conversation
…NT against non-compact int subscripts
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
|
closing as per #150587 (comment):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
EXIT_IF(!_PyLong_IsNonNegativeCompact(...))to_BINARY_OP_SUBSCR_LIST_INTandDEOPT_IF(!_PyLong_IsNonNegativeCompact(...))to_STORE_SUBSCR_LIST_INTbefore the_PyLong_CompactValuecall.Both opcodes currently rely on
_GUARD_TOS_INThaving already rejected non-compact ints, but do not enforce this themselves. If_GUARD_TOS_INTwere relaxed,_PyLong_CompactValuewould be called on a wide int, silently readingob_digit[0]as the index instead of the full value.Fixes gh-150587.