-
-
Notifications
You must be signed in to change notification settings - Fork 35.3k
Doc: Clarify smtplib server reply bytes #149970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
savagemechanic
wants to merge
1
commit into
python:main
Choose a base branch
from
savagemechanic:docs-smtplib-reply-bytes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -168,7 +168,7 @@ A nice selection of exceptions is defined as well: | |
|
|
||
| .. attribute:: smtp_error | ||
|
|
||
| The error message. | ||
| The error message as a :class:`bytes` object. | ||
|
|
||
|
|
||
| .. exception:: SMTPSenderRefused | ||
|
|
@@ -323,9 +323,11 @@ An :class:`SMTP` instance has the following methods: | |
| .. method:: SMTP.verify(address) | ||
|
|
||
| Check the validity of an address on this server using SMTP ``VRFY``. Returns a | ||
| tuple consisting of code 250 and a full :rfc:`822` address (including human | ||
| name) if the user address is valid. Otherwise returns an SMTP error code of 400 | ||
| or greater and an error string. | ||
| ``(code, message)`` tuple, where *message* is the server response as a | ||
| :class:`bytes` object. If the user address is valid, *code* is 250 and | ||
| *message* contains a full :rfc:`822` address (including human name). | ||
| Otherwise *code* is an SMTP error code of 400 or greater and *message* | ||
| contains the error response. | ||
|
|
||
| .. note:: | ||
|
|
||
|
|
@@ -485,8 +487,9 @@ An :class:`SMTP` instance has the following methods: | |
| recipient. Otherwise it will raise an exception. That is, if this method does | ||
| not raise an exception, then someone should get your mail. If this method does | ||
| not raise an exception, it returns a dictionary, with one entry for each | ||
| recipient that was refused. Each entry contains a tuple of the SMTP error code | ||
| and the accompanying error message sent by the server. | ||
| recipient that was refused. Each entry contains a ``(code, response)`` tuple, | ||
| where *code* is the SMTP error code and *response* is the accompanying server | ||
| error response as a :class:`bytes` object. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. similarly here, "as an integer". |
||
|
|
||
| If ``SMTPUTF8`` is included in *mail_options*, and the server supports it, | ||
| *from_addr* and *to_addrs* may contain non-ASCII characters. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good rewrite, but I think it would read better if we said "code is the response code from the server as an integer and message is..."