gh-148871: make LOAD_COMMON_CONSTANT use immortal stackref borrows#149625
Merged
markshannon merged 6 commits intoMay 28, 2026
Conversation
NekoAsakura
requested review from
FFY00,
Fidget-Spinner,
ZeroIntensity,
ericsnowcurrently,
iritkatriel,
markshannon,
savannahostrowski and
tomasr8
as code owners
markshannon
reviewed
May 19, 2026
| // Keep in sync with _common_constants in opcode.py | ||
| assert(oparg < NUM_COMMON_CONSTANTS); | ||
| value = PyStackRef_FromPyObjectNew(tstate->interp->common_consts[oparg]); | ||
| value = PyStackRef_DUP(tstate->interp->common_consts[oparg]); |
Member
There was a problem hiding this comment.
This needs to check the tag.
Could you add PyStackRef_DupImmortal(ref) which would return its argument unchanged and assert that the referenced object is immortal, otherwise it defeats the point of changing PyObject * to _PyStackRef here
markshannon
reviewed
May 19, 2026
| if (opcode == LOAD_COMMON_CONSTANT) { | ||
| assert(oparg < NUM_COMMON_CONSTANTS); | ||
| return Py_NewRef(_PyInterpreterState_GET()->common_consts[oparg]); | ||
| return Py_NewRef(PyStackRef_AsPyObjectBorrow( |
Member
There was a problem hiding this comment.
Suggested change
| return Py_NewRef(PyStackRef_AsPyObjectBorrow( | |
| return PyStackRef_AsPyObjectBorrow( |
These objects are immortal, you can borrow references to them.
Member
Author
|
Thanks for reviewing :') |
markshannon
approved these changes
May 28, 2026
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gc.is_tracked(all/any)True->FalseLOAD_COMMON_CONSTANT#148871