Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jan 8, 2026

@StanFromIreland
Copy link
Member Author

@hugovk maybe you could please take a look?

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.

Comment on lines +26 to +28
Path(".github/CODEOWNERS"),
Path(".pre-commit-config.yaml"),
Path(".ruff.toml"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 9, 2026
@hugovk
Copy link
Member

hugovk commented Jan 10, 2026

Idle thought, we could write:

if not (doc_file or file in RUN_TESTS_IGNORE):

As:

if not doc_file and file not in RUN_TESTS_IGNORE:

I think that's a little clearer?


An unrelated condition that could be made clearer in this file is:

        if not has_platform_specific_change or not platforms_changed:
            a
        else:
            b

Is the same as:

        if not (has_platform_specific_change and platforms_changed):
            a
        else:
            b

And flip to put the positive first:

        if has_platform_specific_change and platforms_changed:
            b
        else:
            a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants