gh-136601: Always set TarInfo.size
to the real file size for sparse files
#136622
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix #136601.
offset_data
being used for sparse files with an additionalsize
PAX keyword #136621 because it would make my case even worse, because the TAR offset recomputation would use the real file size instead of the TAR data size.Lib/test/archivetestdata/
and add a test intoLib/test/test_tarfile.py
? The test setup seems a bit complicated. I'm unsure whether I would do it the right way. That reproducer would be a test case for both bugs / pull requests.size
andGNU.sparse.realsize
keys at the same time #136601