Skip to content

gh-62040: Raise ValueError on invalid *errors* argument in several codecs #136611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jul 13, 2025

@StanFromIreland StanFromIreland changed the title gh-62040: Raise ValueError on invalid *errors* parameter in several codecs gh-62040: Raise ValueError on invalid *errors* argument in several codecs Jul 13, 2025
@efimov-mikhail
Copy link
Contributor

I can see that there's only some changes from last patch:
https://bugs.python.org/file30902/issue17840.patch

For example, I'd like to remove also assert self.errors == 'strict', use _check_strict method in all files, test new changes.

@StanFromIreland
Copy link
Member Author

Ah I forgot about the patch and my grep was too strict, I'll fix all the self.errors cases.

@StanFromIreland StanFromIreland marked this pull request as draft July 14, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants