gh-135608: Add a null check for attribute promotion to fix a JIT crash #135613
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
changed the title
… into sym_new_const_bug
Co-Authored-By: devdanzin <[email protected]>
|
I'll take a look today or tomorrow :) |
tomasr8
reviewed
Jun 18, 2025
tomasr8
approved these changes
Jun 19, 2025
| ex = get_first_executor(testfunc) | ||
| assert ex is not None | ||
| """), PYTHON_JIT="1") | ||
| self.assertEqual(result[0].rc, 0, result) |
There was a problem hiding this comment.
You can remove this line if you use assert_python_ok instead of run_python_until_end ;)
| testfunc(_testinternalcapi.TIER2_THRESHOLD) | ||
| ex = get_first_executor(testfunc) | ||
| assert ex is not None | ||
| """), PYTHON_JIT="1") |
There was a problem hiding this comment.
Is it necessary to pass PYTHON_JIT here? I would think that since this test requires the JIT anyway (via requires_jit_enabled), passing the variable would be redundant. Though another test passes it as well (added here: https://github.com/python/cpython/pull/129194/files#diff-67b5bd915e37f77df79907865982648172c27d3b96fbb072b30a73c6a2735439R649)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Py_uop_sym_new_conston a JIT build #135608