Skip to content

gh-134771: Fix time_clockid_converter() on Cygwin. #134772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

collinfunk
Copy link
Contributor

@collinfunk collinfunk commented May 27, 2025

@collinfunk
Copy link
Contributor Author

Docs CI failed due to me not knowing Sphinx well. I amended and force pushed which should fix it.

Use long for clockid_t instead of int.
@collinfunk
Copy link
Contributor Author

Hi @vstinner, can you check this change? It is similar to what you did for AIX in #112170 and what was done with Dragonfly in #130634.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

Sadly, the CI seems to be stuck.

@vstinner vstinner merged commit d963436 into python:main May 29, 2025
43 checks passed
@vstinner
Copy link
Member

Merged, thanks.

@collinfunk collinfunk deleted the cygwin-clockid_t branch June 4, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants