Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-129015: Move link supression around in a Note for exceptions.rst #129562

Merged
merged 4 commits into from
Mar 3, 2025
Merged

gh-129015: Move link supression around in a Note for exceptions.rst #129562

merged 4 commits into from
Mar 3, 2025

Conversation

nexushoratio
Copy link
Contributor

@nexushoratio nexushoratio commented Feb 2, 2025 •
edited by github-actions bot
Loading

This makes it similar to the same text in constants.rst.

📚 Documentation preview 📚: https://cpython-previews--129562.org.readthedocs.build/

@nexushoratio
Move link supression around in a Note for exceptions.rst (#129015)
8ce0079 
This makes it similar to the same text in constants.rst.
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Feb 2, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 2, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 2, 2025
Closed
StanFromIreland
StanFromIreland approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@StanFromIreland
Copy link
Contributor

Requesting @picnixz

picnixz
picnixz approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this one once I'm back. Otherwise @Eclips4 may do it if he has time.

@picnixz picnixz added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Feb 2, 2025
@picnixz picnixz requested a review from AA-Turner February 16, 2025 00:59
@picnixz picnixz requested a review from AA-Turner February 17, 2025 10:41
@picnixz
Copy link
Member

picnixz commented Feb 17, 2025 •
edited
Loading

@nexushoratio I've taken over your branch 😈 so you can still the credited commit. Thanks for the initial work and for spotting this discrepency which is important as many users mistake those two (I was mistaken when I first started learning Python!!!)

@picnixz
Copy link
Member

picnixz commented Mar 1, 2025

@AA-Turner friendly ping

@picnixz picnixz self-assigned this Mar 2, 2025
@picnixz
Copy link
Member

picnixz commented Mar 2, 2025

@AA-Turner I'd like to merge this one with the following commit title

gh-129015: Clarify notes for `NotImplemented` and `NotImplementedError` (#129564)

I don't really know how to explain that I changed the box from notes to caution without using sloppy English. Do you have some suggestions?

AA-Turner
AA-Turner approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Perhaps "Improve disambiguation between `NotImplemented` and `NotImplementedError`"? But your proposed commit message is also fine, a "caution" admonition is just a fancy nota bene to the reader!

A

@picnixz
Copy link
Member

picnixz commented Mar 3, 2025

I will take your suggestion as it indicates more cleanly what was improved. Mine was too generic. Thanks!

@picnixz picnixz merged commit a85eeb9 into python:main Mar 3, 2025
24 checks passed
@miss-islington-app
Copy link

Thanks @nexushoratio for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2025
@nexushoratio @picnixz
@AA-Turner @miss-islington
pythongh-129015: Improve disambiguation between NotImplemented and …
7cff45e 
…`NotImplementedError` (pythonGH-129562)

---------

(cherry picked from commit a85eeb9)

Co-authored-by: Mike Castle <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 3, 2025

GH-130776 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2025
@nexushoratio @picnixz
@AA-Turner @miss-islington
pythongh-129015: Improve disambiguation between NotImplemented and …
0af78c8 
…`NotImplementedError` (pythonGH-129562)

---------

(cherry picked from commit a85eeb9)

Co-authored-by: Mike Castle <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 3, 2025

GH-130777 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 3, 2025
picnixz added a commit that referenced this pull request Mar 3, 2025
@miss-islington @nexushoratio
@picnixz @AA-Turner
[3.13] gh-129015: Improve disambiguation between NotImplemented and…
e96f914 
… `NotImplementedError` (GH-129562) (#130776)

gh-129015: Improve disambiguation between `NotImplemented` and `NotImplementedError` (GH-129562)

---------

(cherry picked from commit a85eeb9)

Co-authored-by: Mike Castle <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
picnixz added a commit that referenced this pull request Mar 3, 2025
@miss-islington @nexushoratio
@picnixz @AA-Turner
[3.12] gh-129015: Improve disambiguation between NotImplemented and…
43635f2 
… `NotImplementedError` (GH-129562) (#130777)

gh-129015: Improve disambiguation between `NotImplemented` and `NotImplementedError` (GH-129562)

---------

(cherry picked from commit a85eeb9)

Co-authored-by: Mike Castle <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@nexushoratio nexushoratio deleted the nexushoratio-129015 branch March 3, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

@picnixz picnixz

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nexushoratio @StanFromIreland @picnixz @AA-Turner