Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-101100: Make __subclasses__ doctest stable (GH-124577) #124579

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 26, 2024

Using a standard library class makes this test difficult to maintain
as other tests and other parts of the stdlib may create subclasses,
which may still be alive when this test runs depending on GC timing.
(cherry picked from commit 08a467b)

Co-authored-by: Jelle Zijlstra [email protected]


📚 Documentation preview 📚: https://cpython-previews--124579.org.readthedocs.build/

Using a standard library class makes this test difficult to maintain
as other tests and other parts of the stdlib may create subclasses,
which may still be alive when this test runs depending on GC timing.
(cherry picked from commit 08a467b)

Co-authored-by: Jelle Zijlstra <[email protected]>
@JelleZijlstra
Copy link
Member

@Yhg1s would be good to merge this because otherwise the doctests may fail randomly (depending on GC timing).

@Yhg1s Yhg1s merged commit a079922 into python:3.13 Sep 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants