Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119180: annotationlib: Fix __all__, other minor fixes #122365

Merged
merged 3 commits into from
Aug 11, 2024
Merged

gh-119180: annotationlib: Fix __all__, other minor fixes #122365

merged 3 commits into from
Aug 11, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jul 27, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 27, 2024
Open
24 tasks
JelleZijlstra
JelleZijlstra commented Jul 27, 2024
View reviewed changes
Lib/annotationlib.py
Comment on lines +13 to +14
"call_evaluate_function",
"get_annotate_function",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two were missing. The rest of the changes in this file are just formatting.

Lib/test/test_annotationlib.py
else:
self.assertIs(annotate_func, None)


class TestAnnotationLib(unittest.TestCase):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only non-formatting change in this file.

@JelleZijlstra JelleZijlstra changed the title gh-119180: annotationlib: Fix __all__, reformat, other minor fixes gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes Jul 27, 2024
AA-Turner
AA-Turner reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first stdlib module we're proposing to use autoformatting for, is it worth checking on Discourse? Autoformatters are much more opionated than PEP 8, which may be a surprising experience for contributors (note @encukou ran into an issue with a similar tool just whilst making a change to a CPython-only docs extension).

A

@JelleZijlstra
Copy link
Member Author

I hoped it wouldn't be controversial since we're already doing it for some of the Tools/ code. I'm not interested in discussing this issue on Discourse; if there's disagreement, I'll just take out the autoformatting.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) August 11, 2024 23:21
@JelleZijlstra JelleZijlstra merged commit 4534068 into python:main Aug 11, 2024
32 checks passed
@hugovk hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes gh-119180: annotationlib: Fix __all__, run Black other minor fixes Aug 12, 2024
@hugovk hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black other minor fixes gh-119180: annotationlib: Fix __all__, other minor fixes Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@JelleZijlstra @blhsing
pythongh-119180: annotationlib: Fix __all__, formatting (python#122365)
ace7ab9
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @AA-Turner