-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Category
to be Labels
#486
Conversation
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1815 1815
Branches 220 220
=========================================
Hits 1815 1815
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments but otherwise looks good to me.
However I'm a bit confused:
- the module docstring says
"Label a pull request based on its type"
- the enum docstring talks about labels for PRs
but:
classify_by_filepaths
below callsutil.issue_for_PR
to retrieve the issueadd_label
/add_category
accept an issue and label it
It would appear that is the issue being labeled, and if that's indeed the case, then the module docstring and the enum docstrings should be updated. (I think it's fine doing it in this PR.)
I'm not sure about the So I think the current docstrings are actually correct. But somebody with more knowledge about the |
Refactor as requested by @ezio-melotti in #485 (comment).
Also couldn't help but notice the unused import so I removed it in a separate commit. If that's undesired I'll revert that change obviously!