fix(recipe): prevent perpetual re-election if sequence node overflows #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 9, 2023
kazoo/tests/test_lock.py
Outdated
| pyLock_predecessor = f"{pyLock_prefix}-0000000032" | ||
| pyLock = f"{pyLock_prefix}-0000000031" | ||
| pyLock_successor = f"{pyLock_prefix}-0000000030" | ||
| children = ["hello", pyLock_predecessor, "world", pyLock, pyLock_successor] |
kazoo/tests/test_lock.py
Outdated
| def test_get_predecessor_with_overflowed_sequence(self): | ||
| """Validate selection of predecessors with negative sequence. | ||
|
|
||
| This can occur in case of an integer overflow, if the sequence counter is |
kazoo/tests/test_lock.py
Outdated
|
|
||
| def test_get_predecessor_with_overflowed_sequence(self): | ||
| """Validate selection of predecessors with negative sequence. | ||
|
|
kazoo/tests/test_lock.py
Outdated
| client.get_children.return_value = children | ||
| lock = Lock(client, "test") | ||
| assert lock._get_predecessor(pyLock) == pyLock_predecessor | ||
|
|
kazoo/tests/test_lock.py
Outdated
| pyLock_predecessor = f"{pyLock_prefix}0000000030" | ||
| pyLock = f"{pyLock_prefix}0000000031" | ||
| pyLock_successor = f"{pyLock_prefix}0000000032" | ||
| children = ["hello", pyLock_predecessor, "world", pyLock, pyLock_successor] |
angxiang
changed the title
Once sequence node is incremented beyond 2147483647, the sequence overflows into the negative space. When getting predecessors, cast the node sequence from String to int before comparing. Closes python-zk#730
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 96.73% 96.65% -0.09%
==========================================
Files 27 27
Lines 3556 3556
==========================================
- Hits 3440 3437 -3
- Misses 116 119 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once sequence node is incremented beyond 2147483647, the sequence overflows into the negative space. When getting predecessors, cast the node sequence from String to int before comparing.
Closes #730
Why is this needed?
Prevents perpetual re-election if sequence nodes is incremented beyond 2147483647. Previously the sequence node comparison was comparing two Strings, with this change the comparison is done with integers instead. This means that the only re-election due to an integer overflow will happen when incrementing from 2147483647 to -2147483648, but any subsequent increment will not result in a re-election.
Proposed Changes
Does this PR introduce any breaking change?
No