-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature: sector offset #236
Add feature: sector offset #236
Conversation
The code is solid and does what you need. I'm not an expert here so can you explain a bit more on the use cases for this change? If we cannot get more experienced devs here to review I'm tempted to merge b/c this doesn't disrupt the conventional use anyway. |
This change appears to be a convenient way to enforce the "engineering" convention for windroses whereby the bars represent the direction the wind is blowing toward and not from (meteorology). Reviewing the PR, I do notice a spelling typo with |
I made this pr because sometime I need to define the sector starting from 0, not -11.25 (for 16 sectors for example). I modify the setting to adapt this. |
Hi @ocefpaf, |
Co-authored-by: Filipe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll leave it here just a bit more to get a second opinion. If no one can look at it in the next week I'll merge it as-is.
Thanks for the PR!
Apply for the issue #235
Add an argument for the method such that the sector can be edited flexibly.
For example
By default (left), the first sector is [-11.25, 11.25].
Create an 11.25 offset for the sector (right), the first sector is [0, 22.5] and also for the other sectors. And, the bar is rotate 11.25 degrees.
The same thing applies to the box plot,