Conversation
Leaflet.awesome-markers only emits the fa class, so FA6 brand glyphs such as bluetooth never load the brands webfont.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2278
FA6 brand icons (
fa-bluetoothand friends) live in the brands webfont, but Leaflet.awesome-markers only emitsfa, which FA6 treats as solid. I addfa-brandstoextra_classesfor those names. Solid icons likefa-heartare unchanged.Tested with:
python -m pytest tests/test_issue_2278.py