Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use uv.lock instead of test-requirements.txt #3188

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CoolCat467
Copy link
Member

In this pull request, we switch the CI system to use uv.lock instead of test-requirements.txt.

@CoolCat467 CoolCat467 added the dependencies Pull requests that update a dependency file label Jan 19, 2025
@A5rocks
Copy link
Contributor

A5rocks commented Jan 20, 2025

I don't like this change (because I install the dependencies using pip install -r test-requirements.txt!), so I'm a -1 here.

My opinion might shift if there's ever a standardized lockfile format though.

@jakkdl
Copy link
Member

jakkdl commented Jan 20, 2025

I don't like this change (because I install the dependencies using pip install -r test-requirements.txt!), so I'm a -1 here.

My opinion might shift if there's ever a standardized lockfile format though.

presumably one could use uv sync tests for the same effect? I think that might be faster and stuff. But afaict the current setup works fairly well so I don't have strong opinions either way - maybe time to revisit #2790 and see which, if any, of the pain points brought up are still a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants