Open
Conversation
dimbleby
force-pushed
the
type-annotations
branch
3 times, most recently
from
5b50699 to
9250374
Compare
dimbleby
force-pushed
the
type-annotations
branch
from
9250374 to
e87dbf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326, hopefully.
I have let our AI friends loose on fixing the type annotations in this project, so that we now have:
I am aware that this is quite a large pull request - sorry about that - but there was quite a lot to fix.
In general the strategy has been: when returning a value whose type cannot possibly be known ahead of time (eg
foo["bar"], thenAnyis fine. But where it is possible to give more precise types, prefer to do that.That the tests are clean and have to
# type: ignorealmost nothing is good evidence that the types are now usable. I also tried pointing poetry at this version of tomlkit - it cleaned up a handful ofignore, allowed removal of some undesirablecast(), and did not break anything.