-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workaround unsupported metadata version 2.4 in pkginfo #9881
fix: workaround unsupported metadata version 2.4 in pkginfo #9881
Conversation
340ca21
to
7fe24cd
Compare
7fe24cd
to
a3c16f2
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-9881-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e2a8bd5ff6de05d9af03fbefce647b673b13352
# Push it to GitHub
git push --set-upstream origin backport-9881-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8 Then, create a pull request where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix might no longer be required. A new pkginfo
version was released just a few minutes ago that adds support for 2.4.
What would be nice in general is if poetry wouldn't fail when seeing a newer minor version and instead just warns about it.
that already is the behaviour, since pkginfo 1.11.0 |
Thanks for the info.
Poetry did not fail before #9203. However, this resulted in #9195, which is worse than failing. It seems like |
poetry only fails on unexpected metadata versions in some of the code paths, which I think adds to the general confusion (including my own) eg so far as I can see the Probably this is why some people saw a problem and some did not - they either were or were not using pypi / a private repository. |
For anyone looking for a quick fix, you can downgrade poetry with: |
it's upgrading pkginfo that helps, not downgrading poetry |
In my case it was resolved by pip install --upgrade pkginfo
pip install --upgrade poetry
pip install --upgrade pip Aftwards i was able to successfully install ruff in my poetry env via |
pkginfo
will show a warning if it detects metadata version:I decided to not suppress this message.
Related to #9670 (comment)