Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config)!: prefer active python by default #9786

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 20, 2024

From now on Poetry prefers the currently active Python by default. To restore the old behavior the option virtualenvs.use-poetry-python was introduced and must be set to true (default: false).

virtualenvs.prefer-active-python is removed as an option.

@finswimmer finswimmer marked this pull request as ready for review October 20, 2024 11:45
@finswimmer finswimmer added the area/docs Documentation issues/improvements label Oct 20, 2024
@finswimmer finswimmer requested a review from a team October 20, 2024 11:46
@Secrus
Copy link
Member

Secrus commented Oct 20, 2024

I was actually considering if we could remove that option or invert it so that one can choose to use system Python instead of the active one. That seems more instinctive behaviour than what we have currently

@finswimmer
Copy link
Member Author

I was actually considering if we could remove that option or invert it

I wouldn't remove it, but inverting the default would be fine (But I'm biased here, because that's the config I change first in an new installation ;)

@finswimmer finswimmer changed the title docs: virtualenvs.prefer-active-python no longer experimental feat(config)!: change virtualenvs.prefer-active-python default to true Oct 20, 2024
@finswimmer finswimmer added this to the Poetry 2.0 milestone Oct 20, 2024
@Secrus
Copy link
Member

Secrus commented Oct 20, 2024

Well, we could take advantage of the fact that we are making a breaking release and change that to use-system-python that would force usage of the Python version Poetry was installed with. That would give us an open interface to introduce findpython backend without breaking changes but as an alternative (until deemed stable).

@finswimmer
Copy link
Member Author

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

@Secrus
Copy link
Member

Secrus commented Oct 25, 2024

I'm fine with renaming, but I think use-system-python is confusing for the users. While it is consistent with the code base, I guess most users would expect that the Python of their system is meant. Maybe use-application-python or use-poetry-python?

I am fine with use-poetry-python and a proper docs entry explaining that.

@finswimmer finswimmer force-pushed the docs/prefer-active-python branch 2 times, most recently from 357ca04 to 5bc9251 Compare October 25, 2024 10:25
@finswimmer finswimmer force-pushed the docs/prefer-active-python branch 2 times, most recently from 5e8829e to a4d7a98 Compare October 25, 2024 14:35
@finswimmer finswimmer added the impact/changelog Requires a changelog entry label Oct 25, 2024
@finswimmer finswimmer changed the title feat(config)!: change virtualenvs.prefer-active-python default to true feat(config)!: prefer active python by default Oct 25, 2024
Secrus
Secrus previously approved these changes Oct 26, 2024
docs/configuration.md Outdated Show resolved Hide resolved
@radoering radoering added the impact/docs Contains or requires documentation changes label Oct 27, 2024
Copy link

github-actions bot commented Oct 27, 2024

Deploy preview for website ready!

✅ Preview
https://website-fcx6j3foz-python-poetry.vercel.app

Built with commit a57ee6c.
This pull request is being automatically deployed with vercel-action

Secrus
Secrus previously approved these changes Oct 27, 2024
@finswimmer finswimmer force-pushed the docs/prefer-active-python branch from df7869e to 7def964 Compare October 27, 2024 14:29
@Secrus Secrus enabled auto-merge (squash) October 27, 2024 15:17
@Secrus Secrus merged commit 856e5f4 into python-poetry:main Oct 27, 2024
74 checks passed
Secrus pushed a commit to Secrus/poetry that referenced this pull request Oct 27, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements impact/changelog Requires a changelog entry impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants