fix: support underscored repository names from env - #11061
Open
QIU-Guanzong wants to merge 2 commits into
Open
QIU-Guanzong wants to merge 2 commits into
QIU-Guanzong wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/poetry/utils/authenticator.py" line_range="384" />
<code_context>
)
else:
- if name not in self.configured_repositories:
+ repository = self._get_configured_repository(name)
+ if repository is None:
return None
</code_context>
<issue_to_address>
**issue (broader_impact):** Publishing still resolves the repository URL with the original name in `Publisher.publish`, while this helper only normalizes the name for credentials and certificates. When `my-repo` is configured in the project and publishing is requested as `my_repo`, URL lookup raises `RuntimeError` before the new fallback is used.
**Triggers:** When a repository is configured with a hyphenated name and the publish command receives its underscored form.
**Suggested fix:** Use the same exact-then-underscored-to-hyphenated repository lookup for the publishing URL, or expose the resolved repository configuration to `Publisher.publish`.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and if the underscore-to-hyphen fallback resolves a repository incorrectly, the publisher could send stored credentials to the wrong repository endpoint. Reverting prevents future misrouting, but credentials already transmitted cannot be recalled.
Blocking findings: src/poetry/utils/authenticator.py:384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
my_repoandmy-repoare configuredResolves: #7156
Pull Request Check List