-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup json schema validation #819
Conversation
Reviewer's Guide by SourceryThis pull request removes unused JSON schema validation code and its associated test. Class diagram showing JSON validation structure after cleanupclassDiagram
class ValidationError{
<<Exception>>
+pass
}
ValidationError --|> ValueError
class validate_object{
<<function>>
+validate_object(obj: dict, schema_name: str) list[str]
}
note for validate_object "Simplified validation function
Removed unused _get_schema_file"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Secrus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fcfdea7
to
fe7e5ee
Compare
@Secrus This was just marked as draft because of the failing downstream tests so that it is ready now, isn't it? |
@radoering yes, it should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Secrus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Related to: python-poetry/poetry#2965
Some small cleanup of unused code.
Summary by Sourcery
Chores: