Start from zero index when reading GimpPaletteFile #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #6639
When Pillow reads a Gimp palette file into palette bytes, the palette bytes are not populated by the data from the start. Rather, the loop index continues increasing when reaching header fields or a comment, making the final positions of the entries somewhat arbitrary. So this only increases the loop index when an entry is found.
This PR also pulls in the idea from #5552 that palettes can be less than 256 entries - once the end of the Gimp palette file is reached, let's stop populating the palette bytes.
This is similar to #6640, but that PR seeks read additional bytes from the file, limited by new class variables. I'm reluctant to go there, so this PR helps by at least solving the underlying logic problem.