Added running_in_another_thread() #8518
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible way to help #8492. Alternative to #8501
I've created a Tests/helper.py function called
running_in_another_thread()
that uses a global variable andinspect
to determine if a test has already started running in another thread, so that we can return early if we would only like the test to run in one thread at a time.This is used here in two cases
register_handler
at the beginning, and removes the handler at the end, fails when the test is run across multiple threads. My thinking is that if it ok forregister_handler
to operate across threads, and that it doesn't need to register multiple handlers in parallel. So this PR returns early from the relevant test if it is already running in another thread.Pillow/Tests/test_core_resources.py
Lines 50 to 54 in 16372dd
across multiple threads. I again think that
Image.core.set_alignment
doesn't need to be run across multiple threads simultaneously, so this PR returns early.