Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow HWND to be passed to ImageGrab.grab() on Windows #8516
base: main
Are you sure you want to change the base?
Allow HWND to be passed to ImageGrab.grab() on Windows #8516
Changes from 4 commits
607acbf
28e5b92
9622266
f682197
7763350
a44b306
288d77e
4b88670
a6c941a
acba5c4
c5e89ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 370 in src/display.c
Codecov / codecov/patch
src/display.c#L369-L370
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably never happen that
SetThreadDpiAwarenessContext
is found butGetWindowDpiAwarenessContext
is not.However, if it somehow does happen, we would then use
dpiAwareness
before its initialized after measuring the window size. So we should ideally either fallback to PER_MONITOR_AWARE context ifGetWindowDpiAwarenessContext
is not found, or skip the reset a few lines later.Check warning on line 387 in src/display.c
Codecov / codecov/patch
src/display.c#L386-L387
Check warning on line 450 in src/display.c
Codecov / codecov/patch
src/display.c#L450
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added this for the
error:
branch but not for the success branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've updated the commit to add it or success as well.
Check warning on line 464 in src/display.c
Codecov / codecov/patch
src/display.c#L464