-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8 #8183
Conversation
@@ -50,7 +50,6 @@ jobs: | |||
fedora-39-amd64, | |||
fedora-40-amd64, | |||
gentoo, | |||
ubuntu-20.04-focal-amd64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could either update the image to upgrade the default Python version, but given Pillow 11.0 is set for release in October 2024, it's not that long until Ubuntu 20.04's EOL in April 2025 so we could just remove it?
I don't mind too much either way.
The ""Could not resolve host: mirrorlist.centos.org; Unknown error" should be fixed in a cibuildwheel release later today: |
oss-fuzz/CIFuzz is hardcoded to use Python 3.8.3 so the CIFuzz tests fail now with "ERROR: Package 'pillow' requires a different Python: 3.8.3 not in '>=3.9'". https://github.com/Yay295/Pillow/actions/runs/9960735804/job/27520667252 |
There's a PR to change that to 3.10.14 here: google/oss-fuzz#12027 |
Related issues and PRs: google/oss-fuzz#11419, google/oss-fuzz#9638, google/oss-fuzz#9532, google/oss-fuzz#11420. In the meantime, shall we do something about the failing CI? It's training us to ignore CIFuzz failures. For example, remove the check or make it always report passed. |
I've created #8239 to skip it. |
Pillow's oss-fuzz is currently failing, because Pillow main has [dropped support for Python 3.8](python-pillow/Pillow#8183). #12027 attempts to resolve this by upgrading the base builder to Python 3.10, but the [latest status update](#12027 (comment)) over there says that Pillow [fails in that branch with](https://oss-fuzz-gcb-logs.storage.googleapis.com/log-e19625fb-a984-47b1-be32-f92b4c76fc7f.txt) > Step 17: Step 6/11 : RUN ln -s /usr/local/bin/python3 /usr/local/bin/python && ln -s /bin/true /usr/local/bin/yum_install && ln -s /bin/true /usr/local/bin/yum && cd $SRC/Pillow && git submodule update --init wheels/multibuild && bash $SRC/build_depends.sh Step 17: ---> Running in 932abd1dc89a Step 17: �[91mln: failed to create symbolic link '/usr/local/bin/python': File exists So this pull request removes the python symlink in order to try and help. cc @hugovk --------- Co-authored-by: Andrew Murray <[email protected]>
Pillow's oss-fuzz is currently failing, because Pillow main has [dropped support for Python 3.8](python-pillow/Pillow#8183). Until a global solution is provided for #11419, this installs Python 3.9 to allow Pillow to work again. cc @hugovk Co-authored-by: Andrew Murray <[email protected]>
Python 3.8 reaches end of life in October 2024:
Pillow 11.0.0 is planned for 2024-10-15 and will drop Python 3.8: