Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: in py3.13 exec does not implicitly update locals() #8057

Closed
wants to merge 1 commit into from
Closed

FIX: in py3.13 exec does not implicitly update locals() #8057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@
def get_version():
version_file = "src/PIL/_version.py"
with open(version_file, encoding="utf-8") as f:
exec(compile(f.read(), version_file, "exec"))
return locals()["__version__"]
lcl = {}
exec(compile(f.read(), version_file, "exec"), lcl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lcl is the second argument to exec(). Looking at https://docs.python.org/3.13/library/functions.html#exec, this would be globals, right? So maybe lcl is a confusing name, because it makes one think that locals is being used instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yes it should have been second (I like the new ability to pass them as kwargs :) )

return lcl["__version__"]


configuration = {}
Expand Down
Loading