Fix astimezone conversion with dateutil timezones - #1006
Open
ryanchou1994 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
astimezone()can lose its timezone or return the wrong wall time when the target is adateutiltimezone. Itsfromutc()implementation performs datetime arithmetic, which currently dispatches into Pendulum's duration arithmetic.Perform the conversion on a native
datetimefirst, then use the existing reconstruction to preserve the Pendulum subclass, target timezone and fold. No new dependency or API is added.Fixes #820.
Pull Request Check List
Validation: the new regression matrix fails in 38 cases before the fix and passes afterward. On Linux with Python 3.11, the full suite passes with both pure-Python and native extensions (1,925 passed, 3 skipped each); mypy and the applicable Python lint/format hooks also pass. The matrix covers dateutil, built-in, ZoneInfo and Pendulum timezones, DST folds, naive inputs, local-time conversion and a subclass.