Autoformat CSV files #180
Merged
Autoformat CSV files #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoformat CSV files to ensure that - Event rows are sorted properly - Fields do not contain extraneous spaces before or after data - Files contain the expected newlines at the end
|
It looks like this has broken something and should be reverted until it can be fixed. I thought I opened this as a draft PR, but if it was marked ready to review / merge, that was my fault. GitHub can be weird about pushing commits from CI and allowing validators to still run, so this may need to be debugged from that configuration standpoint. |
|
I was able to get this working by separating the pull request validation from the commit push formatting (see https://github.com/invisibleroads/github-actions-experiments). Thanks so much for the original github action workflows. It took some getting used to but I think I understand it now. Sorry about the workflow failed notifications spam. Hope you're well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoformat CSV files to ensure that
This branch also applies the formatting to the existing CSV files, which resulted in some rows being resorted to match the sorting intent that has been followed in most changes.
This change is not yet complete. I'd like to include a GitHub Actions task that runs this formatter on PRs and commits the changes back, which will require GitHub App authentication in order to allow the automated commits to trigger other GHA workflows.