Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2020 01 some fixes #132

Closed
wants to merge 9 commits into from
Closed

2020 01 some fixes #132

wants to merge 9 commits into from

Conversation

mickp
Copy link
Collaborator

@mickp mickp commented Jan 13, 2020

Some fixes from #124 (which will be closed in favour of a different implementation) that are not specific to that feature.

@mickp
Catch exceptions during shutdown.
0592368 
Leaving this unhandled could prevent other devices in the same process (e.g. on a controller) being shut down.
@mickp
Don't leave caller waiting for data if camera not enabled.
0058fd9
@mickp
Added error tolerance to get_all_settings.
5e0f57e 
get_all_settings reports the values of problem settings as None.
Previously, we considered adding a new entry, __errors__, to the returned dict, but this is adding an item that is not a setting to a dict where everything else is a setting, and would require clients to handle this key as a special case.
@mickp
Fix logging typo.
71850b3
@mickp
Don't start collection thread until hardware is enabled.
1fef4b3
@mickp
TestCamera throws exceptions if it should be initialized but isn't.
5ff43e0
@mickp
Only evaluate necessary transforms.
f11d893 
Dict evaulation is not lazy: previously, this code evaluated all allowable transforms before picking the appropriate one. This is now fixed by breaking it down into the rotation transfrom, then passing the result to one function from a dict of flip transform functions.
@mickp
Changed logging level for problems disabling devices on shutdown.
78366c8
@mickp
Linting devices.py.
c2fc012
@carandraug
Copy link
Collaborator

This is now merged after some history editing:

  1. the commit that changed style for pyling also renamed the _call_if_callable function to call_if_callable but didn't change it on the places where the function was being called. I kept the style changes but reverted the name change (which I think was the accidental part).

  2. I squashed the three commits about handling exceptions during shutdown (the last two were fixups anyway)

  3. changed commit message to include on first line the method or class being affected.

@carandraug carandraug closed this Jan 13, 2020
@mickp
Copy link
Collaborator Author

mickp commented Jan 13, 2020

Yep - that name change was an accident. Thanks for catching it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickp @carandraug