Report an out-of-range duration as invalid instead of erroring#1512
Open
c-tonneslan wants to merge 1 commit into
Open
Report an out-of-range duration as invalid instead of erroring#1512c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1511.
The
durationformat checker registersraises=isoduration.DurationParsingException, butisodurationparses components withdecimal.Decimal, so an extreme value like"P1E1000000D"raisesdecimal.Overflow(adecimal.DecimalException/ArithmeticError) instead. That escaped the format checker uncaught rather than the instance being reported invalid.This adds
decimal.DecimalExceptionto theraisestuple, so such an instance is treated as an invalid duration (the checker returnsFalse/ raisesFormatError) rather than propagating adecimalerror.Added a regression test in
test_format.py(skipped whenisodurationisn't installed).ruffand the format test suite pass. Happy to add a CHANGELOG entry if you'd like one.