Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No byteswarning #1290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

No byteswarning #1290

wants to merge 3 commits into from

Commits on Nov 23, 2024

  1. fix: No more BytesWarnings 

    Fixes python-hyper#1236.

This patch makes all header operations operate on `bytes` and converts all headers and values to bytes before operation. With a follow up patch to `hpack` it should also increase efficiency as currently, `hpack` casts everything to a `str` first before converting back to bytes: https://github.com/python-hyper/hpack/blob/02afcab28ca56eb5259904fd414baa89e9f50266/src/hpack/hpack.py#L150-L151
    @BYK @Kriechi
    BYK authored and Kriechi committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5841683 View commit details
    Browse the repository at this point in the history

  2. add more upstream tests

    @BYK @Kriechi
    BYK authored and Kriechi committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    3924557 View commit details
    Browse the repository at this point in the history

  3. refactor headers bytes encoding

    @Kriechi
    Kriechi committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5c6a7f5 View commit details
    Browse the repository at this point in the history