Reorder dashboard cards by user's browser languages#180
Reorder dashboard cards by user's browser languages#180
Conversation
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/bce329f5-881d-4092-b19d-a7bed12a8937 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/bce329f5-881d-4092-b19d-a7bed12a8937 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/9303e6ae-44fe-4547-9351-f81ab0cd622f Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
StanFromIreland
left a comment
There was a problem hiding this comment.
-1 on this without a way to also optionally sort them by % completion/alphabetically. While this may be more convenient for some it will also not allow them to view the dashboard how it currently displays languages.
| clones | ||
| venv | ||
| __pycache__/ | ||
| *.pyc |
There was a problem hiding this comment.
This is covered by the above, I suggest we just add a template from https://github.com/github/gitignore to cover everything (like the .idea/ directories some IDEs create).
There was a problem hiding this comment.
I've pushed a simplification; to be honest I feel like the template you linked would be an overkill for our modest project; we can discuss it independently in a separate PR
I think engaging people to contribute is a higher priority purpose than providing a dry information. By bringing the user language(s) to front it is harder to miss them, on a page that already force you to scroll to see through all languages (we have now 25 of them). In my opinion moving one or two languages in front is a small disruption to the order. To satisfy use case of "universal" view we could add an opt-out toggle to "unpin" users language(s). Would a thumbtack icon as first on right in top navbar be understandable/discoverable? We could/should make it disabled (grayed out) if none of user's languages is listed on the dashboard. |
Something like this would be good. But, maybe have the thumbtack in the corner of the cards? |
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/b832ebdb-d3dc-40ec-a886-66ba818048a0 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Agent-Logs-Url: https://github.com/python-docs-translations/dashboard/sessions/b832ebdb-d3dc-40ec-a886-66ba818048a0 Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
position: relativeto.cardand new.pin-btnCSS rules insrc/style.csstemplates/index.html.jinjawith new logic that:localStorage(default: pinned)reorder()helper puts pinned cards first (innavigator.languagespriority), unpinned cards stay in original sort orderlocalStorage, re-runsreorder()col.querySelector('[id]')before accessing.id📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/180/merge/