Skip to content

HTML/Jinja lint & format#173

Open
m-aciek wants to merge 14 commits intomainfrom
jinja-lint
Open

HTML/Jinja lint & format#173
m-aciek wants to merge 14 commits intomainfrom
jinja-lint

Conversation

@m-aciek
Copy link
Copy Markdown
Collaborator

@m-aciek m-aciek commented Mar 22, 2026

@m-aciek m-aciek marked this pull request as ready for review March 22, 2026 23:36
@m-aciek m-aciek requested a review from StanFromIreland March 22, 2026 23:37
@m-aciek m-aciek changed the title Jinja lint HTML/Jinja lint & format Mar 23, 2026
Comment thread .pre-commit-config.yaml
- id: deptry
args: [".", "--per-rule-ignores", "DEP002=python-docs-theme", "--package-module-name-map", "gitpython=git,sphinx-lint=sphinxlint"]

- repo: https://github.com/djlint/djLint
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a dead project, no releases since 2024, are there no alternatives? It seems to work alright currently.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My quick research implied it is mature and stable, and there's no better alternative. It looks stagnant on PyPI, but the repo still receives commits. The GitHub project had updates as recently as Nov 2025, and the docs were updated in 2026, which indicates some ongoing maintenance.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact they have Renovate set up to do updates multiple times a day, and automerge them without human review, is a bit odd:

https://github.com/djlint/djLint/commits/master/

Also no cooldown, so a very good way to be among the very first to be exposed to a new vulnerability...

https://blog.yossarian.net/2025/11/21/We-should-all-be-using-dependency-cooldowns

We're on a pinned tag not on master, which helps, but tags are immutable and a vuln could rewrite the tags.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue with a suggestion to add the cooldown: djlint/djLint#1783.

It's only library like that that offers an autoformatter.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as the whole litellm thing happened the day after Hugo’s message, I think we should wait with this PR till they make such changes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They've added cooldowns recently and pinned dependencies.

@StanFromIreland StanFromIreland marked this pull request as draft March 27, 2026 21:31
@m-aciek
Copy link
Copy Markdown
Collaborator Author

m-aciek commented Apr 30, 2026

@copilot resolve the merge conflicts in this pull request

Copilot AI and others added 3 commits April 30, 2026 08:07
Co-authored-by: m-aciek <9288014+m-aciek@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit ed54625. The resolution merges all new features from main (dark mode, GitHub navbar link, Analytics link) while keeping this PR's formatting improvements (meta keywords, explicit logo dimensions, named endblocks, style cache version bump to 3).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • git.afpy.org
    • Triggering command: /usr/bin/python python -m pytest tests/ -v (dns block)
  • python-docs-es.readthedocs.io
    • Triggering command: /usr/bin/python python -m pytest tests/ -v (dns block)
  • python.org.br
    • Triggering command: /usr/bin/python python -m pytest tests/ -v (dns block)
  • www.flowdas.com
    • Triggering command: /usr/bin/python python -m pytest tests/ -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@m-aciek m-aciek marked this pull request as ready for review April 30, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint .jinja files

4 participants