Closed
Conversation
❌ Deploy Preview for pydis-static failed.
|
Contributor
|
Request a review from me if this is ready for review |
jb3
force-pushed
the
jb3/user-props-store
branch
3 times, most recently
from
d9ddde5 to
7f9844a
Compare
Update imports in API models to include UserModSettings Add migration for UserModSettings model
Contributor
|
Hello @jb3, what's the status with this PR? |
Member
Author
|
No time for now, closing. |
Contributor
|
You can go party every other day and stay up until 2 AM but when the Python Discord brotherhood needs you, it's "No time for now". Curious. |
Member
Author
Feel free to take it, my time constraint primarily revolves around the fact I don't know Django or DRF at all. |
Contributor
|
5 Years of Python Discord Django Addicts Anonymous, "Joe". 5 Years. |
Member
Author
??????????????????? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
UserModSettingsmodel to store properties related tomoderator preference that we currently store in Redis. This is part of a wider
scale effort to migrate away from Redis any data which would be anything more
than slightly annoying in the event it gets lost.
This will require bot side changes but it is not a breaking change to merge this
when it is ready. Some manual migration will be required to move the current
moderator settings from Redis into this new PostgreSQL table.
I have added a basic copy of the cache data that we use on Redis, adding some
constraints to ensure that we do not end up retaining partially valid data (i.e.
a moderator schedule that has a start time but no duration).
Tasks required for this PR:
processing time when it is not needed
moderators settings
Any input from those wiser with Django than me would be appreciated to
maximimise the optimisation of these endpoints and models.