Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #286 by clarifying the existing extraction-pattern semantics, without changing matching behavior.
**includes one or more filename characters, while**/can match zero directory levels without consuming the filename prefix. Therefore**._*.pydoes not match._module.pyorpkg/._module.py;**/._*.pydoes.*: it matches one or more characters, not an empty string.pathmatch()docstring consistent and add parametrized coverage of the documented behavior.The current semantics date back to the original
pathmatchimplementation; this deliberately avoids a potentially incompatible change to extraction mappings.Verification
On CPython 3.13.5:
python -m pytest -q tests/test_util.py babel/util.py tests/messages/test_extract.py tests/messages/test_extract_python.py tests/messages/test_js_extract.py tests/messages/test_jslexer.py— 95 passed.ruff check babel/util.py tests/test_util.py(0.14.10) — passed.git diff --check— passed.extract_from_dir()on root-level and nested._module.pyfiles plus a normalpkg/module.py: the reported pattern extracted all four files, while the documented replacement extracted only the normal file. These are behavioral documentation tests, not a claim of a production-code red/green fix.Sphinx 9.1.0 strict HTML builds were run against both this branch and an unmodified archive of base commit
6ba6701. Both reported the same five existing diagnostics:extract_javascriptdocstring indentation and unresolved targets indates.rst,dev.rst(two), and the unrelated entry-point section ofmessages.rst. The documentation build is not reported as passing. No full CLDR-dependent suite or multi-platform test matrix was run locally.AI disclosure
This contribution was prepared and verified with Hermes Agent. No independent human review is claimed.